Closed sanbrock closed 7 months ago
NXaperture:
NXbeam:
NXinstrument:
NXprocess:
NXsample:
NXsensor:
@sanbrock: from all these changes in the above-mentioned base classes I recall that I introduced exactly one: NXsample/sample_history and that still backup to enable the possibility for linking in a parent or connection to a workflow management (system) (work with Area A!)
Let me comment on some of the other cases, personal suggestions: NXsample: (i.e. the concept of a sample in its thermodynamic environment)
NXprocess:
NXinstrument:
NXbeam:
NXaperture:
NXsensor:
Feedback from Code Camp:
More feedback from Code Camp discussion:
first step is implemented
The rendered version can be found here: https://hdf5.gitlab-pages.esrf.fr/nexus/fairmat_2023/
The restructuring looks good. However, some subsets of proposed classes in contributed do currently not show up as entries in the HTML summary list of the above-mentioned rendered version: https://hdf5.gitlab-pages.esrf.fr/nexus/fairmat_2023 (was this version generated from commit 8f0b40b using which make which-command
?). Unlisted contributed classes include a substantial number of NXcg* base classes and NXms . Is there a reason that these have no corresponding subset page? Some of these classes are searchable though via the quicklink right-hand side navigation pane.
This is the respective page of the nexus-fairmat-proposal which includes an equivalent rst cgms-structure.rst file https://github.com/FAIRmat-NFDI/nexus_definitions/blob/fairmat/manual/source/cgms-structure.rst
for these NXcg_ and NXms_* contributed classes.
Here is the CI that builds the fairmat_2023 branch:
https://gitlab.esrf.fr/hdf5/nexus/fairmat_2023/-/blob/main/.gitlab-ci.yml
I used make local
git clone https://github.com/FAIRmat-NFDI/nexus_definitions.git definitions
cd definitions
git checkout -t origin/fairmat_2023
make install
make local
Note that I need to run this manually. It doesn't get triggered when you push changes to that branch.
Check when the last build was: https://gitlab.esrf.fr/hdf5/nexus/fairmat_2023/-/pipelines
There is an issue about rendering html for merge requests: https://github.com/nexusformat/definitions/issues/1280
@sanbrock I have a suggestion you could incorporate as part of this PR around the proposed NXcoordinate_system_set about McStas. Here is the current language:
Many application definitions in NeXus refer to this McStas coordinate system.
In reality, all application definitions use McStas (at least that's my understanding), as stated in the design doc. So perhaps it could be simply:
NeXus uses the McStas coordinate system.
And elsewhere you could add a note like:
One use of NXcoordinate_system_set is to transform from McStas to the coordinate system of an application definition.
Reasonable?
NeXus uses the McStas coordinate system.
Makes it sound like NeXus depends on McStas. That's not the case. The NeXus coordinate system is the same as defined by McStas and this information might be useful for those at neutron instruments. Other standards must also use that coordinate system.
The wording in the design section is succinct.
The NeXus coordinate system is shown below. Note that it is the same as that used by McStas (http://mcstas.org/).
Lots of discussion preceded this wording. Let's stick with that.
👍
Hi @mkuehbach @sanbrock @PeterC-DLS, if you could re-check the unresolved conversations prior to our Telco on Wednesday, that would be great! Thanks!
Hi @mkuehbach @sanbrock @PeterC-DLS, if you could re-check the unresolved conversations prior to our Telco on Wednesday, that would be great! Thanks!
I did so yesterday. If you go to the files tab and click on the conversations drop-down, you see there are 38 unresolved and 32 resolved conversations.
Ok the conversations drop-down didn't work for me. Instead I used the "hidden conversations" link on this page to find the unresolved conversations.
Please check the modifications and resolve the conversations if the answers are OK.
Base Classes and Application Definitions to support: