Closed erikrikarddaniel closed 2 weeks ago
master
branch :x:base
to dev
Hi @erikrikarddaniel,
It looks like this pull-request is has been made against the erikrikarddaniel/ampliseq master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the erikrikarddaniel/ampliseq dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 92f7fda
+| ✅ 281 tests passed |+
#| ❔ 6 tests were ignored |#
!| ❗ 1 tests had warnings |!
LGTM, just one comment. Also, GTDB release 220 came out in April, maybe we should add that as well
Coming up. I've run my pipeline and produced the files. Now this needs to be submitted for storage and I'm not sure I'll make it before going on vacation next week.
@d4straub : The test_reftaxcustom
fails because https://zenodo.org/record/4310151/files/rdp_species_assignment_18.fa.gz
cannot be found. I can't see that this happened with my PR but I also think that I saw all tests pass the other day?
Several tests use that file, so I assume that was a temporal problem and resumed the test. Hope it will pass ;)
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).Finally, last year's release of GTDB in SBDI-GTDB vetted format.