Open edmundmiller opened 1 year ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit b94ee9e
+| ✅ 154 tests passed |+
#| ❔ 3 tests were ignored |#
!| ❗ 8 tests had warnings |!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 599d277
+| ✅ 154 tests passed |+
#| ❔ 3 tests were ignored |#
!| ❗ 8 tests had warnings |!
Thanks for the detailed feedback, and once again thanks for creating the templates and tutorials, they were amazing!
Stick to a complementary colour theme, the Red is sort of OK but the turquoise blue looks 'off' to my eyes. I would recommend trying https://coolors.co/, fix the nf-core green and follow from that.
The orange is actually the complementary color to the nf-core green and turquoise is part of our school colors (Which are actually green and orange). But thanks coolors looks awesome, I'll adjust those!
I don't understand the purpose of the red/green colours inuitiively either
That's what should go in the dead space in the top right-hand corner, a legend! :upside_down_face:
The turquoise was for GROSeq and the orange for everything else
I borrowed form the London bus network with the white arrows
That's great! I was trying to get at that they were subworkflows, but just metrics and graphs and didn't get used in the pipeline aftewards.
It's a a little cramped
I thought all of those spaces were a bit cramped as well, I think I took out a segment or two in each of them, I don't know why I was limiting myself :grimacing:
Re colours: fair enough! You don't have to stick with nf-core of course, just keep to a nice palette together :)
@jfy133 I've attached a copy of an edited map. We would really appreciate your feedback! There may be some font issues on my side but let me know if that looks good. Thank you for your time!
Hi @sruthipsuresh
It's a bit hard for me to say overall as the SVG seems to be a bit borked when I cehck it (e.g. fonts).
But some feedback anyway:
Hi @jfy133 , thank you so much for your detailed and prompt response! Here is a new iteration with your feedback incorporated (PDF format to prevent font issues). I have also included two options to indicate input/outputs to mitigate the issue in 6:
Almost there arrows help a lot! The offset BEDTools intersect looks off, youc ould make the line/arrow leading to it shorter if you don't want to make the page bigger.
I still don't find the colours work well together personally, but I think I remeber @Emiller88 says he is following some scheme somewhere, so I'll elave that ;)
Closes #68