search

nflverse / nflreadr

Efficiently download nflverse data
https://nflreadr.nflverse.com/
Other
62 stars 12 forks source link

update join coalesce to coerce to data.frame #220

Closed tanho63 closed 1 year ago

tanho63 commented 1 year ago

Running into errors when passing in data.tables, namely:

Error in [.data.table(x, keys_x) : When i is a data.table (or character vector), the columns to join by must be specified using 'on=' argument (see ?data.table), by keying x (i.e. sorted, and, marked as sorted, see ?setkey), or by sharing column names between x and i (i.e., a natural join). Keyed joins might have further speed benefits on very large data due to x being sorted in RAM.

annoyed. just forcing to data.frame everywhere

tanho63 commented 1 year ago

Yeah I think as long as old behaviour works I'm good with it