nfroidure / svgicons2svgfont

Concatenate SVG icons and ouput an SVG font
http://nfroidure.github.io/svgiconfont/
MIT License
339 stars 71 forks source link

Replace punycode dependency with string iteration #173

Closed andersk closed 3 weeks ago

andersk commented 3 weeks ago

Proposed changes

The spread operator has been available since Node 5.0.0, and iterates strings over their code points (not code units), as expected here. There’s no need to use the punycode library for this.

Code quality

License

To get your contribution merged, you must check the following.

Join

My NPM username: andersk

nfroidure commented 3 weeks ago

Adding link to mozdev for reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String#utf-16_characters_unicode_code_points_and_grapheme_clusters

nfroidure commented 3 weeks ago

Published under svgicons2svgfont@15.0.0 . Thanks for your help.