search

nfroidure / svgicons2svgfont

Concatenate SVG icons and ouput an SVG font
http://nfroidure.github.io/svgiconfont/
MIT License
339 stars 71 forks source link

Ligatures #27

Closed sabberworm closed 9 years ago

sabberworm commented 9 years ago

I’ve sent a pull request to svg2ttf implementing ligature support. This means svgicons2svgfont should now start generating ligature glyphs in SVGs. The implementation is very hacky, I’m not offended if you want me to improve it, just tell me (I’m rather picky with pull requests on my own projects)…

nfroidure commented 9 years ago

Hi @sabberworm

I really appreciate your PRs. Supporting ligatures will be a great improvement for this library.

Sadly, there is no tests coming with your PRs. I can do it if you wish but it will require me to dive deeper into the ligature subject and take a while.

If you can, please add some tests for this new feature, otherwise, i'll try to do so as soon as possible. Please let me know if there is something to be aware of to do the right tests.

Of course, i'm here to help if you have any question.

nfroidure commented 9 years ago

https://github.com/nfroidure/svgicons2svgfont/issues/19

nfroidure commented 9 years ago

Reading your code, i think that to support ligatures, the best would be to change the glyph.codepoint option to a glyph.codepoints one and to also consider ligatures as glyphs but with several codepoints.

It will ship in the 2.0 version since some other breaking changes will appear in that version.

Closing this PR since i will change its implementation.