bosborn
commented
2 years ago Are you doing to this on a background thread? Are you using a PowerManager WakeLock? Wondering if the file is partially copied over causing different errors. But not sure why it fully works the second time unless it is a temporary partial thing.
The first error makes it a little farther and fails to find the required tables. The second error fails a few steps earlier trying to enable foreign keys (pragma) due to a corrupted database.
Does this happen to all GeoPackages or only some? If not all, can you provide an example file?
Turned your code into a test. Ran with version 6.1.2 on a Nexus 5X API 31 emulator (closest to a Samsung Note 5 I could think of). Works fine and could not duplicate the errors.
public void safGeoPackageMapTileModuleProvider(DocumentFile[] pFile,
final Context context /*, IFilesystemCache cache*/) {
String GEO_PACKAGE_EXTENSION = ".gpkg";
//int pThreadPoolSize, final int pPendingQueueSize
//super(Configuration.getInstance().getTileFileSystemThreads(), Configuration.getInstance().getTileFileSystemMaxQueueSize());
//Log.i(IMapView.LOGTAG, "Geopackage support is BETA. Please report any issues");
//tileWriter = cache;
// Get a manager
GeoPackageManager manager = GeoPackageFactory.getManager(context);
// Available databases
//String[] list = manager.databases().stream().toArray(String[]::new);
//Log.i(IMapView.LOGTAG, "Geopackage database list: " + Arrays.toString(list));
List<String> names = new ArrayList<>();
// Import database but strip the .gpkg extension from the file name
for (int i = 0; i < pFile.length; i++) {
String name = pFile[i].getName();
name = name.replace(GEO_PACKAGE_EXTENSION, "");
//Log.i(IMapView.LOGTAG, "Geopackage database new entry: " + name);
//if (StringUtils.indexOfAny(name, list) == -1) {
//Log.i(IMapView.LOGTAG, "Geopackage database new entry: " + pFile[i].getName());
manager.importGeoPackage((pFile[i]));
names.add(name);
//}
}
// Available databases
List<String> databases = manager.databases();
//Log.i(IMapView.LOGTAG, String.format(Locale.getDefault(), "Geopackage database size: %d", databases.size()));
// Open database
for(String name : names){
//for (int i = 0; i < databases.size(); i++) {
//GeoPackage open = manager.open(databases.get(i));
GeoPackage open = manager.open(name);
//boolean newTile = tileSources.add(open);
//Log.i(IMapView.LOGTAG, String.format(Locale.getDefault(), "Geopackage database open: %s (%s)", databases.get(i), newTile ? "true":"false"));
assertNull(open.foreignKeyCheck());
assertTrue(open.enableForeignKeys());
GeoPackageValidate.validateMinimumTables(open);
assertNull(open.quickCheck());
assertNull(open.integrityCheck());
open.close();
}
}
eclectice
Please fill out as much known and relevant information as possible.
Version Information:
api 'mil.nga.geopackage:geopackage-android:6.1.2'Expected Results:
However, following import, it appears "corrupt." However, after restarting the app, the "failed" map renders correctly.
Import feature
Importing with copy locally option selected
Observed Results:
Failed to import popup message
But it loads fine after app restart
Output:
Error 1
``` 2022-04-11 10:46:28.214 16539-16539/? I/OsmDroid: Geopackage database list: [5312] 2022-04-11 10:46:28.217 16539-16539/? I/OsmDroid: Geopackage database size: 1 2022-04-11 10:46:28.704 16539-16539/? E/com.my.app.android.component.OsmMapFragment: GPKG file setupMap() load error: mil.nga.geopackage.validate.GeoPackageValidate.validateMinimumTables(GeoPackageValidate.java:155) mil.nga.geopackage.GeoPackageException: Invalid GeoPackage. Does not contain required tables: gpkg_spatial_ref_sys & gpkg_contents, GeoPackage Name: 5312 at mil.nga.geopackage.validate.GeoPackageValidate.validateMinimumTables(GeoPackageValidate.java:155) at mil.nga.geopackage.GeoPackageCreator.createGeoPackage(GeoPackageCreator.java:228) at mil.nga.geopackage.GeoPackageManagerImpl.open(GeoPackageManagerImpl.java:1101) at mil.nga.geopackage.GeoPackageManagerImpl.open(GeoPackageManagerImpl.java:1070) at com.my.app.android.gpkg.tiles.raster.SafGeoPackageMapTileModuleProvider.Error 2
``` 2022-04-11 11:16:15.032 1920-1920/? I/OsmDroid: Geopackage database list: [5312] 2022-04-11 11:16:15.037 1920-1920/? I/OsmDroid: Geopackage database size: 1 2022-04-11 11:16:15.118 1920-1920/? E/com.my.app.android.component.OsmMapFragment: GPKG file setupMap() load error: android.database.sqlite.SQLiteConnection.nativeExecuteForCursorWindow(Native Method) android.database.sqlite.SQLiteDatabaseCorruptException: database disk image is malformed (code 11) ################################################################# Error Code : 11 (SQLITE_CORRUPT) Caused By : The database disk image is malformed. (database disk image is malformed (code 11)) ################################################################# at android.database.sqlite.SQLiteConnection.nativeExecuteForCursorWindow(Native Method) at android.database.sqlite.SQLiteConnection.executeForCursorWindow(SQLiteConnection.java:930) at android.database.sqlite.SQLiteSession.executeForCursorWindow(SQLiteSession.java:836) at android.database.sqlite.SQLiteQuery.fillWindow(SQLiteQuery.java:62) at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:143) at android.database.sqlite.SQLiteCursor.getCount(SQLiteCursor.java:132) at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:219) at android.database.AbstractCursor.moveToNext(AbstractCursor.java:268) at android.database.CursorWrapper.moveToNext(CursorWrapper.java:202) at mil.nga.geopackage.db.ResultUtils.buildResults(ResultUtils.java:395) at mil.nga.geopackage.db.GeoPackageConnection.queryResults(GeoPackageConnection.java:192) at mil.nga.geopackage.db.GeoPackageCoreConnection.queryResults(GeoPackageCoreConnection.java:998) at mil.nga.geopackage.db.CoreSQLUtils.foreignKeyCheck(CoreSQLUtils.java:363) at mil.nga.geopackage.db.GeoPackageCoreConnection.foreignKeyCheck(GeoPackageCoreConnection.java:194) at mil.nga.geopackage.db.GeoPackageCoreConnection.enableForeignKeys(GeoPackageCoreConnection.java:147) at mil.nga.geopackage.GeoPackageCreator.createGeoPackage(GeoPackageCreator.java:222) at mil.nga.geopackage.GeoPackageManagerImpl.open(GeoPackageManagerImpl.java:1101) at mil.nga.geopackage.GeoPackageManagerImpl.open(GeoPackageManagerImpl.java:1070) at com.my.app.android.gpkg.tiles.raster.SafGeoPackageMapTileModuleProvider.Steps to Reproduce:
It is not relevant since it is my custom codes
Relevant Code:
The code snippet where the exception occurs at
(SafGeoPackageMapTileModuleProvider.java:90):GeoPackage open = manager.open(databases.get(i));I'm not sure if removing the extension ".gpkg" (GEO_PACKAGE_EXTENSION) from the file name before adding the file into the
GeoPackageManager.importGeoPackage()call is a problem or not.Test Files:
Additional Information: