Closed zsteinkamp closed 5 months ago
I'll bump the versions after the next PR. Thanks @ryepup !
Thanks for the swift actions @zsteinkamp
This allows for on-the-fly certificate reconfiguration (e.g. adding a domain) by using nginx -s reload.
I justed wanted to add (for future searchers :-) ) that this was not only a problem for adding a domain, but also for the renewal.
Proposed changes
Fixes Issue #50 - Purge cached cert/key from shared dictionary zone (if applicable) when we receive a replacement. This allows for on-the-fly certificate reconfiguration (e.g. adding a domain) by using
nginx -s reload
.Thank you @NetForce1 for raising the issue and your clarity in describing the symptoms and repro case.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)Confirmation of fix
Before: 2 hosts in certificate![Screenshot 2024-03-22 at 1 34 53 PM](https://github.com/nginx/njs-acme/assets/8418898/793b1e35-8383-427c-a0cb-042cd0d4fd2f)
Reload nginx (via![Screenshot 2024-03-22 at 1 37 35 PM](https://github.com/nginx/njs-acme/assets/8418898/6a687176-078d-4b48-b983-4407b58e5ab3)
docker compose exec nginx bash
)After: 1 host in certificate![Screenshot 2024-03-22 at 1 35 37 PM](https://github.com/nginx/njs-acme/assets/8418898/d0656ab0-12ac-4540-8200-f56cd8abfc1c)