search

nginx / unit

NGINX Unit - universal web app server - a lightweight and versatile open source server that simplifies the application stack by natively executing application code across eight different programming language runtimes.
https://unit.nginx.org
Apache License 2.0
5.37k stars 323 forks source link

Add a GitHub discussions badge to the README #1299

Closed mjang closed 3 months ago

mjang commented 3 months ago

I need to update this with the NGINX color code.

I don't claim to know any/all PR requirements -- I'm using this as a learning experience.

ref https://github.com/nginx/unit-docs/issues/150

mjang commented 3 months ago

I think the commit subject would be better as

Add a GitHub discussions badge to the README

I agree and have updated the Git commit

ac000 commented 3 months ago

Actually, while you're at it, you could create another separate patch that adds a 'tooltip' for the repo status button, we have one for the CI button, something like "Repo Status - Active"

ac000 commented 3 months ago

Hi @mjang

Looks good. Just one thing, as a general rule we use our corporate email addresses (@f5.com/@nginx.com) when committing.

You can set it in the unit repository via

$ cd /path/to/unit
$ git config user.email EMAIL-ADDRESS

You can also adjust your commit to use it with

$ git commit --amend --no-edit --author="NAME <EMAIL-ADDRESS>"
mjang commented 3 months ago

Hi @mjang

Looks good. Just one thing, as a general rule we use our corporate email addresses (@f5.com/@nginx.com) when committing.

Hi @ac000 . Thanks for the guidance. I've now updated the commit with my corporate email address. This should now be ready for approval.

ac000 commented 3 months ago 
$ git range-diff 5cae8086...98983f3f
-:  -------- > 1:  e77a0c16 Tests: explicitly specify 'f' prefix to format string before printing
-:  -------- > 2:  c9dced37 Tests: print unit.log on unsuccessful unmount
1:  5cae8086 ! 3:  98983f3f Add a GitHub discussions badge to the README
    @@ Commit message

         - With NGINX green (hex code 009639)

    +    Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
    +
      ## README.md ##
     @@