nginxinc / nginx-otel

Apache License 2.0
157 stars 19 forks source link

libcares.so.2 missing dependency #67

Open fede843 opened 3 days ago

fede843 commented 3 days ago

Describe the bug

libcares.so.2. is needed in target system

To reproduce

Build the module, import the .so file to the target system, and run Nginx with it.

Expected behavior

Nginx running

Your environment

Docker

Additional context

We are using the official NGINX image. We are creating the module .so in a docker stage, and copying over a new image based on the official image. It will not run, since it needs libcares.so.2. After installing libc-ares2 in this case in the target image, dependency is fulfilled. There is no mention of this anywhere.

thresheek commented 3 days ago

Hi @fede843!

Is there a specific reason you're building the otel module on your own on top of an official image? Asking because we provide a image variant with the module built-in: nginx:otel and nginx:alpine-otel.

fede843 commented 2 days ago

Hi @thresheek thanks for the info. I guess at the time we start using the official image we were not into telemetry. And we have been using the regular image since there. This is so much simpler then. I'll give it a shot. I was not aware of it.

p-pautov commented 2 days ago

libc-ares-dev dependency is mentioned in build instructions, and usually library dependencies imply non-dev package as a runtime dependency.