search

ngld / OverlayPlugin

Yet another OverlayPlugin fork.
Other
229 stars 39 forks source link

PartyChangedEvent not called correctly in all cases #123

Closed quisquous closed 4 years ago

quisquous commented 4 years ago

Requeuing in an instance or having somebody disconnect may cause the current party (via PartyChangedEvent) to be incorrect. I suspect but am not 100% sure that the FFXIV plugin is not calling the PartyChangeDelegate that's been registered in all the cases it should, but I have not tracked this down. It could also be that it is sent, but it is incorrect?

See: https://discordapp.com/channels/551474815727304704/594899820976668673/687441928337621009

quisquous commented 4 years ago

Ah, with some debugging, I figured it out. IDataRepository.GetCombatantList does not have all the combatants when PartyListChangedDelegate is called. In the case of a reconnect, the PartyListChangedDelegate has all the right values but the combatant is missing entirely (not just the wrong type). I'm not sure what the solution is yet, but that's the problem.