Better to have a validation check of email id before database query

ngoworldcommunity / NGOWorld-Backend

This is the official repository for Milan's server side codes.

https://api.milanhub.org

MIT License

7 stars 26 forks source link

Better to have a validation check of email id before database query #12

Closed vikramsaha7 closed 1 year ago

vikramsaha7 commented 1 year ago

https://github.com/MilanCommunity/Milan-Backend/blob/811736276d02ab00026a6ffe4305b9ab329d0778/routes/club/Club.js#L16

github-actions[bot] commented 1 year ago

Hello @vikramsaha7, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan-Backend/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support Happy OpenSource 🚀

tamalCodes commented 1 year ago

Hi @vikramsaha7 , thanks for bringing that to my notice however with respect to https://github.com/MilanCommunity/Milan/pull/1041 we will be merging the API routes too for the Login and signup of users.

So in short this file will be removed and then a single API will be there which will be responsible to handle login and register. Would you like to work on it ?

venom-10 commented 1 year ago

I would like to work on this.

tamalCodes commented 1 year ago

[!IMPORTANT] The branch to make a PR to/ fork would be beta

Hi , you can start working on the issue, assigning it to you. Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

📑 Checklist

Setup Guide to understand the setup and the .env(s) for development locally.
Contribution Guide to understand what type of PRs are accepted and how to make them.
Workflow Guide to understand what goes behind the scene, and why your PR doesn't get merged immediately.

Do drop a star, Happy Opensource 💚

tamalCodes commented 1 year ago

Notice 🚩

Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same.

There might be more Issues/PR that are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it.

If you think that this is a mistake, please drop an email at milanhub.org@gmail.com, and we will get back to you.

Regards, Team Milan.