ngrx / platform

Reactive State for Angular
https://ngrx.io
Other
8.05k stars 1.98k forks source link

fix(router-store): use non-const enum to allow isolatedModules tsconfig option #4554

Closed dangrussell closed 1 month ago

dangrussell commented 1 month ago

Using a const enum here triggers "Cannot access ambient const enums when 'isolatedModules' is enabled." error when "isolatedModules" is true in tsconfig.json.

"isolatedModules" is set to true by default in new Angular CLI applications.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify[bot] commented 1 month ago

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
Latest commit 9572b25cff042cf22227a39aa206efdc23dcafc8
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6706ab4701064a000860d0e5
markostanimirovic commented 1 month ago

Thanks @dangrussell!