search

ngrx / store

RxJS powered state management for Angular applications, inspired by Redux
MIT License
3.9k stars 311 forks source link

Support for Angular 4 (Ionic 3) #383

Closed devmao closed 7 years ago

devmao commented 7 years ago

Hi,

Soon I have to start a new project in Ionic 3 and I really want to use this great module but the question is, when do you think that you are able to release a stable version that supports Angular 4?

Thank you

fxck commented 7 years ago

It already does support angular 4.

devmao commented 7 years ago

yes in master but it's not released

fxck commented 7 years ago

No, the version on npm supports angular 4 just fine.

devmao commented 7 years ago

good but the latest version (2.2.1) has angular 2 as peer dep

javico2609 commented 7 years ago

it's working fine in ionic 3, right now i used an do not have problem

scrapcupcake commented 7 years ago

Can confirm, am using store with Angular 4 just fine; the peer dep is annoying, for sure, but doesn't stop any actual code working.

devmao commented 7 years ago

Yes, it seems working well, at least on my simple app. Btw, I'm also using these guys:

Therefore, for now, I can ignore these npm warnings:

npm WARN @ngrx/effects@2.0.2 requires a peer of @angular/core@^2.0.0 but none was installed.
npm WARN @ngrx/store@2.2.1 requires a peer of @angular/core@^2.0.0 but none was installed.
npm WARN angularfire2@2.0.0-beta.7-pre requires a peer of @angular/common@^2.0.0 but none was installed.
npm WARN angularfire2@2.0.0-beta.7-pre requires a peer of @angular/compiler@^2.0.0 but none was installed.
npm WARN angularfire2@2.0.0-beta.7-pre requires a peer of @angular/core@^2.0.0 but none was installed.
npm WARN angularfire2@2.0.0-beta.7-pre requires a peer of @angular/platform-browser@^2.0.0 but none was installed.
npm WARN angularfire2@2.0.0-beta.7-pre requires a peer of @angular/platform-browser-dynamic@^2.0.0 but none was installed.
npm WARN @angular/core@2.2.1 requires a peer of rxjs@5.0.0-beta.12 but none was installed.
npm WARN @angular/core@2.2.1 requires a peer of zone.js@^0.6.21 but none was installed.
pmulac commented 7 years ago

It might technically work with Angular v4, but the old peer dependencies prevent the use of npm-shrinkwrap (this is critical for serious apps). We really need a release that is compatible with v4.

brandonroberts commented 7 years ago

We just got back from ng-conf this past week, so we'll need to finish up the next release but it will the peer dependencies issue will be fixed.

PG2000 commented 7 years ago

@brandonroberts Any news on that ?