nguyenngoc2505 / google_adwords

3 stars 0 forks source link

FYI - Do not eager load the lib folder #2

Open olivierobert opened 7 years ago

olivierobert commented 7 years ago

There is a long discussion about this topic: https://github.com/rails/rails/issues/13142

Usually, 1) load each library when required instead of loading all the lib folder as it breaks the eager loading behavior or Rails or 2) move lib to the app folder

nguyenngoc2505 commented 7 years ago

@olivierobert Thanks, I've read it before. And I will improve it later.

nguyenngoc2505 commented 7 years ago

Fixed. https://github.com/nguyenngoc2505/google_adwords/commit/d8942b05f1e076868e6374e35f37d4c6d62b0474

akostadinov commented 7 years ago

I think that problem with lib is auto_loading. Using eager_loading should be fine (according to the discussion you linked to).