ngx-metaui / rules

One Framework to build a highly declarative and customizable UI without using templates.
Other
39 stars 8 forks source link

Remove dependency on typescript-collections #59

Open fkolar opened 4 years ago

fkolar commented 4 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[X] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Currently some parts of code are relaying on this 3th-party lib to utilize its Dictionary implementation and there is a less a needs for it as it can be replaced by TS Maps with specific custom key implementation.

Its a overhead that code needs to work with.

Expected behavior

Replace all the occurences of Typescript-collections with native TS Maps. Mostly it's inside Context.ts, where we are using it to cache activation.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX  
- Platform:  

Others: