search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 218 forks source link

feat: upgrade to Angular 10 #568

Closed fabiomartino closed 3 years ago

fabiomartino commented 3 years ago

Hi,

With this PR the Angular dependency and file structure will be updated to latest (ATM of writing) to latest versions.

I reproduce the structure for the new json introduced in version 10, I mean tsconfig.base.json.

Still a warning (not due to this PR) with angular-hmr... it cause with the version 2.1.3 the common warning

CommonJS or AMD dependencies can cause optimization bailouts.

CommonJS_or_AMD I made a PR to "solve" this warning with latest angular version https://github.com/PatrickJS/angular-hmr/pull/87

Tested with Angular + Material and Bootstrap as UI Hope it help

Cordially

Fabio

PatrickJS commented 3 years ago

i published the hmr fixes as 3.0.0

fabiomartino commented 3 years ago

i published the hmr fixes as 3.0.0

Thx PatrickJS

fabiomartino commented 3 years ago

BTW, if you update <preference name="android-minSdkVersion" value="19"/> to <preference name="android-minSdkVersion" value="22"/> in __cordova._config.xml it should fix the CI for the mobile builds.

Change made.

sinedied commented 3 years ago

Thanks! Expect a new release with your changes soon 🎉

sinedied commented 3 years ago

:tada: This PR is included in version 9.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: