search

ngyv / re-modelr

A simple-to-use pure javascript object-relational mapping to manage data.
MIT License
0 stars 0 forks source link

[REFACTOR] Move validation logic to model descriptors #18

Closed ngyv closed 6 years ago

ngyv commented 6 years ago

Temporary hack of defining date properties as string. This is until the property parser is built.

Also, validation failure does not block instantiation of models.

codecov[bot] commented 6 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.87%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #18      +/-   ##
=========================================
+ Coverage   92.73%   93.6%   +0.87%     
=========================================
  Files           5       5              
  Lines         454     469      +15     
=========================================
+ Hits          421     439      +18     
+ Misses         33      30       -3
Impacted Files Coverage Δ
lib/model-descriptors.js 100% <100%> (ø) :arrow_up:
lib/base-model.js 93.65% <100%> (+3.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 717cb77...96e9345. Read the comment docs.