nhn / tui.calendar

🍞📅A JavaScript calendar that has everything you need.
http://ui.toast.com/tui-calendar
MIT License
11.99k stars 1.29k forks source link

When having eventView as only "time", events don't show up in calendar when event's duration is greater than 24hours. #1234

Open sravya-k-raj opened 2 years ago

sravya-k-raj commented 2 years ago

2.0.0

Test Environment

Chrome, Firefox

Current Behavior

I want to have only "time" view for my calendar, hence removed rest all parameters such as "task","allday","milestone" etc from eventView. With this change things work fine as long as the event duration is less than 24 hours. When an event duration is more than 24 hours, it is not showing up in my calendar "timeline" view.(only want time view)

Is there any way to fix it and show events with more than 24 hours duration in my time view.

// Write example code
week: {
          eventView: ['time'],
          taskView: false
        },

Expected Behavior

Show events with more than 24 hours duration in calendar's time view.

adhrinae commented 2 years ago

@sravya-k-raj

It's an intended implementation and we are not willing to change it at this moment.

Please check this documentation about conditions making events as all-day.

https://github.com/nhn/tui.calendar/blob/main/docs/en/apis/event-object.md#isallday

You might need to fork the project and change controller logic for your purpose. Then these functions are related to this issue.

https://github.com/nhn/tui.calendar/blob/main/apps/calendar/src/helpers/grid.ts#L249 https://github.com/nhn/tui.calendar/blob/main/apps/calendar/src/controller/week.ts#L225

pierre-H commented 1 year ago

Hi @adhrinae I understand that the default way of showing events is the current one. But I don't understant why we don't allow users to display events with durations with more than 24 hours in the time zone ? At least, when we set isAllday: false ?

I believe it's related to #652 and #604 and #265

So many people are asking for this feature. Why is it blocked ?

(Thanks to the NHN team for they great work !!!)

adhrinae commented 1 year ago

@pierre-H

I admit that this feature is still getting upvoted, but this needs major refactoring and I cannot guarantee how hard it will be.

The team behind TOAST UI projects are working on various internal projects and the resource of the team is too limited to implement this feature. Please understand that.