nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme
https://nhs-r-community.github.io/NHSRplotthedots/
Other
47 stars 21 forks source link

Inconsistent colours between special/common cause plotting & icons #196

Closed andrjohns closed 4 months ago

andrjohns commented 9 months ago

Hi All! When using the default colours & icons for special/common cause highlighting in the PowerBI visual we've noticed some (very) small inconsistencies in the colour values:

Type ptd_spc_colour icon
common_cause #7b7d7d #BFBFBF
special_cause_improvement #289de0 #0072C6
special_cause_neutral #361475 #8000C0
special_cause_concern #fab428 #FF6600

Also as an FYI, it looks like the colours in the excel SPC template (from future NHS) very slightly differ from these as well.

Is there a reference document/spec for the exact colour values to use here? Possibly a little pedantic, but always good to be careful!

ThomUK commented 9 months ago

Hi @andrjohns, thanks for raising this - not pedantic at all. Projects have been forked over smaller annoyances than this! Do you have a screenshot of the difference that we could use to bring the problem to life for people?

NHSRplotthedots aims to follow the NHS England tools as closely as possible. @MatthewCallus do you have a set of colour codes you would prefer us to move towards for consistency? Shall we standardise on the current icon colours?

MatthewCallus commented 9 months ago

Thanks, @ThomUK, for adding me.

I have discussed this with the team. We currently use different colours in different tools, and I believe the colours for the icons are different too. We will look to standardise these, as well as make any necessary changes to increase accessibility (adding purple to the mix has made this a bit harder). I'll make a note to come back with an update.

@andrjohns, if you want the colours currently in use, I'm happy to share, but hopefully we'll be in a position to update these in the next week or so.

MatthewCallus commented 9 months ago

We have settled on the following colours:

Blue: #00B0F0 Orange: #E46C0A Purple: #490092 Grey: #A6A6A6

These have already been applied to the latest version of single chart and multi-chart Excel tools. We'll be updating other tools over time. These colours only apply to the charts. The icons have not been changed – would take a long time – but I will be updating our icons on GitHub.

andrjohns commented 9 months ago

Thanks for the clarification, much appreciated!

@pli9 FYI on the updated colour codes

ThomUK commented 9 months ago

Thanks @MatthewCallus. @tomjemmett would you mind re-opening this issue - we should implement the standard colours here.

Comparison below (the white dot is the new standard colour)

Screenshot_20231207-061658.png

marcosfabietti commented 9 months ago

https://github.com/nhs-r-community/NHSRplotthedots/pull/199 pull request for this

ThomUK commented 4 months ago

This was closed by #199, @tomjemmett would you be able to close this issue?