Issue #196: Inconsistent colours between special/common cause plotting & icons

nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme

https://nhs-r-community.github.io/NHSRplotthedots/

Other

47 stars 21 forks source link

Issue #196: Inconsistent colours between special/common cause plotting & icons #199

Closed marcosfabietti closed 9 months ago

marcosfabietti commented 9 months ago

Updated ptd_spc_colours.R, with new colors based on icons

[x] added unit tests and checked code coverage with covr::report() (should aim for 100%)
[x] ran devtools::document()
[x] ran lintr::lint_package() and resolved all lint warnings and notes
[x] ran styler::style_pkg() to make sure code matches the style guidelines
[x] ran R-CMD CHECK and resolved all issues

marcosfabietti commented 9 months ago

made changes to the test files and passed all the other checks. but this one: Warning: file=tests/testthat/test-ptd_create_ggplot.R,line=329,col=19,[brace_linter] Any function spanning multiple lines should use curly braces. not sure what the problem is @tomjemmett , could you guide me how to fix it?

tomjemmett commented 9 months ago

I'll have a look, suspect that's a new lint warning but it's safe to ignore for now!