search

nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme
https://nhs-r-community.github.io/NHSRplotthedots/
Other
47 stars 21 forks source link

register S3 methods even if they are internal #213

Closed francisbarton closed 3 weeks ago

francisbarton commented 1 month ago

Recent versions of {roxygen} highlight that

you should register S3 methods even if they are internal link

The NAMESPACE roclet now reports if you have S3 methods that are missing an @export tag. All S3 methods need to be @exported even if the generic is not. link

This means that the methods in to_datetime.R need an @export tag and to be included in the NAMESPACE.

francisbarton commented 3 weeks ago

Closed by #219