Export S3 methods in to_datetime.R

nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme

https://nhs-r-community.github.io/NHSRplotthedots/

Other

47 stars 21 forks source link

Export S3 methods in to_datetime.R #219

Closed francisbarton closed 3 weeks ago

francisbarton commented 1 month ago

[ ] added unit tests and checked code coverage with covr::report() (should aim for 100%)
[x] ran devtools::document()
[x] ran lintr::lint_package() and resolved all lint warnings and notes
[x] ran styler::style_pkg() to make sure code matches the style guidelines
[x] ran R-CMD CHECK and resolved all issues

This PR adds @export lines to a couple of methods in to_datetime.R. See issue #213

tomjemmett commented 3 weeks ago

I think #221 is replicating a lot of these commits?

francisbarton commented 3 weeks ago

I think #221 is replicating a lot of these commits?

Yeah I'm really sorry about that, something in my process ended up pulling in a load of commits into some PRs that were relevant to other PRs... I was meaning to go back and clean things up! Hopefully merging in some of my PRs to main will have left the remaining diffs looking less messy...

The perils of having multiple PRs in parallel (if your git/gh skills are as sketchy as mine seem to be sometimes!)