niamurrell / value-app

Calculate the per-use value of purchases over time.
https://valuemax.herokuapp.com/
MIT License
12 stars 18 forks source link

wrap all promises in try/catch #24

Closed anacoimbrag closed 6 years ago

anacoimbrag commented 6 years ago

What was a problem? (include issue # if applicable)

13

How does this PR fix the problem?

I Wrapped all promises calls with try catch

Check lists (check x in [ ] of list items)

Additional Comments (if any)

At first I could not reproduce the issue, but later I was able to identify where the problem is.

niamurrell commented 6 years ago

@anacoimbrag Thanks for taking a stab at this, I'll pull it down & test asap

niamurrell commented 6 years ago

Looks great @anacoimbrag—nice work. Bit delayed while traveling for work but this is now merged 😄