search

nianticlabs / mickey

[CVPR 2024 - Oral] Matching 2D Images in 3D: Metric Relative Pose from Metric Correspondences
https://nianticlabs.github.io/mickey/
Other
501 stars 31 forks source link

Minor bug in e2eprobabilisticprocrustes #16

Closed JayKarhade closed 3 months ago

JayKarhade commented 4 months ago

Hi!

There seems to be a minor bug at

https://github.com/nianticlabs/mickey/blob/06e62e5a119bd7a02c18a3c2759e2e68b907492c/lib/models/MicKey/modules/utils/probabilisticProcrustes.py#L176

The variables R, t_metric, best_inliers are initialized only if num_valid_h > 0, and this runs into an error if num_valid=0.

axelBarroso commented 3 months ago

Hello!

Thanks for spotting that, it has now been fixed. Thank you!