search

niccokunzmann / open-web-calendar

Embed a highly customizable web calendar into your website using ICal source links
https://open-web-calendar.quelltext.eu
GNU General Public License v2.0
215 stars 70 forks source link

Check documentation on ALLOWED_HOSTS #469

Closed niccokunzmann closed 2 months ago

niccokunzmann commented 2 months ago

Apparently, I misunderstood what flask-allowed-hosts does. Thus, the documentation needs to be checked if it is correct.

See

@vmario89, you contributed this feature - Could you check if it does what you wanted and if the documentation is correct? @mikitsu, you had a deeper look into this, too. What are your thoughts on this? We have this feature but I think the documentation does not reflect what is actually going on.

We're using Polar.sh so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work.

Fund with Polar

mikitsu commented 2 months ago

I agree the documentation and actual behavior do not match. In my opinion, both features (i.e. the current implementation and what the documentation says) are for fairly niche use-cases, but I think limiting clients is more useful. Hence, I'd suggest updating the documentation.