niccokunzmann / open-web-calendar

Embed a highly customizable web calendar into your website using ICal source links
https://open-web-calendar.quelltext.eu
GNU General Public License v2.0
215 stars 70 forks source link

added static files caching to improve load times #518

Closed besque closed 1 month ago

besque commented 1 month ago

This PR addresses issue #439 by implementing static file caching.

Changes made:

Testing done:

RESULT :

before: image

after: image

niccokunzmann commented 1 month ago

nice. would you be happy to write tests for this? There are already tests that make requests. It would be nice to check that static files get cached but the dynamic ones don't. How is that for you?

I want to make sure this does not get destroyed in the future.

niccokunzmann commented 1 month ago

I have a cache time for the resources like .ics urls that the calendar requests. it would make sense to use that on the dynamic resources, maybe. What is your idea?

besque commented 1 month ago

hey sure, gladly!

I'm not sure which dynamic resources to add a cache time to, I feel the current behaviour works just fine.

I'll focus on writing tests to verify the current caching behaviour works as intended.

niccokunzmann commented 1 month ago

Thanks!