Spectator Camera

[nicholas-maltbie]

Description

Added a basic spectator camera and player into game flow

• When player joins mid game, they are made a spectator
• Spectators either follow spectator points on the map or follow a player on the map
• Spectators can swap between targets by pressing left shift or left ctrl
• Spectators can rotate the camera using the mouse around their target
• Players can turn into spectators when they enter a specific zone (aka finish line)

There is no auto end round when all players finish the level but it's what we have so far :)

How Has This Been Tested?

Tested locally on one and multiple clients to ensure spectator player works in the following cases

• Switching between targets
• Joining mid game
• Hitting finish line (might have cheated a bit for this one)

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

[swiimii]

I downloaded the branch and did some manual tests. The spectating itself feels good for a first iteration with one exception. When I press Shift to swap my spectator target, my target changes twice: once when I press shift, and once again when I release shift. This should probably be changed so the target changes only once per press.

[nicholas-maltbie]

Great comment, I will attempt to address the press and release of buttons via input system in unity 😄

Found a thread online about the topic: https://forum.unity.com/threads/how-would-you-handle-a-getbuttondown-situaiton-with-the-new-input-system.627184/

If all you're interested in is getting one call on press and one on release, hook into started and cancelled.

Code (CSharp):

myAction.started += /* button was pressed */;
myAction.cancelled += /* button was released */;

If you want to continuously be notified for as long as the button is held, check the "Continuous" box on the action and use performed and cancelled.

Code (CSharp):

myAction.performed += /* button was pressed or is held */;
myAction.cancelled += /* button was released */;

From Feb 19th, 2012 by Rene-Damm - https://forum.unity.com/threads/how-would-you-handle-a-getbuttondown-situaiton-with-the-new-input-system.627184/#post-4232515

There also seems to be more follow up discussion about the input system here - https://forum.unity.com/threads/how-would-you-handle-a-getbuttondown-situaiton-with-the-new-input-system.627184/#post-5379081 interesting to look into in the future for sure.