search

nickdodd79 / vscode-gulptasks

A gulp task visualization and execution extension for Visual Studio Code
MIT License
7 stars 6 forks source link

Execute a task with double click #11

Closed Spown closed 6 years ago

Spown commented 6 years ago

and/or with enter. Thank you.

nickdodd79 commented 6 years ago

Not done much with keyboard or mouse events in vscode yet, so will need to brush up on that before this request is in place. Watch this space.

nickdodd79 commented 6 years ago

This request won't be possible just yet due to restrictions with the tree provider offered by vscode.

Currently it only allows either single or double click events, but not both. I have raised a feature request with the vscode team to provide more event handlers, so we will need to wait on them.

nickdodd79 commented 6 years ago

The vscode team have said they are looking to get double click handling out in a not-too-far-in-the-future release. As soon as it is available, I will be adding the ability to execute a task using double clicks.

nickdodd79 commented 6 years ago

Hi @Spown

Double click has now been added to v1.2.0. Instead of waiting for vscode to natively support double click, I have used some timer trickery to make it possible.

Nick.

Spown commented 6 years ago

I think I know what you've done. Clever 👍 . Also, I see this interval: 183ms message in the Gulp Tasks Output before a task initiated via doubleclick is started. I presume it's a debug leftover? Otherwise it seems to work fine. Thank you!

I'm leaving this issue open for the case VSC does implements input events and you decide implement it natively. Or you may close it anytime you want if you so please.

nickdodd79 commented 6 years ago

Hey @Spown

Glad you like the solution :-) Thanks for reminding me of the interval output - yep, used it for debugging and shouldn't be in there. I've removed it and will push it in the next release.

As this feature is now available, I'm gonna close this issue. I was hoping some new handling would be in the recent 1.25.0 release of vscode, but it looks like we will be awaiting a bit longer. Once it is in there, I will make the coding change, which should be seamless from a user perspective.

Nick.