search

nickspring / charset-normalizer-rs

Truly universal encoding detector in pure Rust - port of Python version
https://crates.io/crates/charset-normalizer-rs
MIT License
33 stars 3 forks source link

Lint fixes #16

Closed chris-ha458 closed 1 year ago

chris-ha458 commented 1 year ago

Using cargo clippy -- -Wclippy::pedantic to find some further low hanging fruit. The false positive rate is quite high, so I'm tempted to include some line allows like #![allow(cargo::range_plus_one)]

However I'm not sure you would agree that it is a good idea since the default cargo clippy does not complain. One compromise would be to have it enabled in a separate branch like pedantic or dev where we could use to merge recent fixes to look through the course in a strict(pedantic), yet context aware(we know some are false positives) way.

nickspring commented 1 year ago

I've checked it with -Wclippy::pedantic. TBH it looks like very excessive = a lot of work for nothing. However, we can enable this mode if you prepare the branch without warnings.