search

niclasleonbock / hacktoberfest-status

This little tool helped you to track your Hacktoberfest progress back in the day when there was no official way to check.
15 stars 28 forks source link

Add meta/og tags for status page #23

Closed niclasleonbock closed 7 years ago

niclasleonbock commented 7 years ago

Now that we can share the status page we also need meta tags and og tags for the status page, at least when in sharing mode.

The description should be context-dependent (something like the sharing message, e.g. "$username completed 11 pull requests for Hacktoberfest!".

Also, the page title should be changed in sharing mode, e.g. to "Hacktoberfest stats of $username".

All the other fields can simply be copied over from the index page.

I'll let the decision open to you if you want to add some if-blocks to the view or rather copy it.

This relates to #7 and #6

Tardog commented 7 years ago

Hi! I’ve implemented the context-dependent status page, but before I submit a PR for this, I would like to take the time to add some tests for the status page in both sharing mode and "normal" mode.

niclasleonbock commented 7 years ago

Hi, sure, take your time. Thanks for the notice and the contribution :)

Tardog commented 7 years ago

Just a quick heads up: I will have time to finish this tomorrow.