search

nicoSWD / put.io-adder

macOS put.io client that acts as handler for magnet: links and .torrent files, and adds them to your put.io download queue
MIT License
195 stars 23 forks source link

Persistent App Crashing after Download Completes #10

Closed jonmacchio closed 9 years ago

jonmacchio commented 10 years ago

Hi,

Every completed download causes the app to crash, consistent report from console shows this:

Application Specific Information:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff7a4b9240'
abort() called
terminating with uncaught exception of type NSException'

Otherwise app is running fantastically!

nicoSWD commented 10 years ago

Hi,

thanks for taking the time to report this. I just pushed a new version which hopefully fixes this issue.

Please give it a shot and let me know if it works.

https://github.com/nicoSWD/put.io-adder/releases/tag/v2.8

Thanks!

edwardsanchez commented 10 years ago

Unfortunately after downloading the new version the app still crashes after a transfer is complete.

nicoSWD commented 10 years ago

Crap! It seemed to work for me. Back to the drawing board... Will look into it soon'ish.

Thanks for letting me know!

gmogames commented 10 years ago

+1 for this issue.

Also happened to me just now with the latest version 2.8

Application Specific Information: *\ Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff7aad6030' abort() called terminating with uncaught exception of type NSException.

Maybe the app is calling the saveAccessToken or the addMagnet methods with a null parameter, because the only 2 places where you actually use the length method are in these 2.

What I did:

nicoSWD commented 10 years ago

Thanks guys! I can confirm the issue, and I'm pretty sure it's because of this line:

notification.contentImage = [[NSImage alloc] initWithContentsOfURL:[NSURL URLWithString:contentImage]];

I've been working on a whole new release for the past week, in which (among other things) I wrapped this line between a @try {} @catch() block, and I haven't been having problems with it.

Not sure if I'll wait until the new version is finished, or if I'll push a fix before. I'll decide soon.

Thanks again! The feedback is greatly appreciated.

rc1 commented 9 years ago

A fix would be much appreciated. Great app, but slightly unusable with multiple transfers.

joshkerr commented 9 years ago

Crashes for me too. Persistent for the past few builds of this app. Seems to happen after a few seconds. It does successfully add my torrent before crashing. I actually went back to version 1.5 which is rock solid. I lose the ability to see what is in my queue but at least I don't have crashes happening all the time.

nicoSWD commented 9 years ago

Hey y'all!

Sorry for the late response. Please give the last release a try, which attempts to fix this issue.

https://github.com/nicoSWD/put.io-adder/releases/tag/v2.9

Let me know if this works for you!

Thanks!

rc1 commented 9 years ago

Thanks for this. No problems so far. Like the status bar progress icon.

nicoSWD commented 9 years ago

Thanks! :) I'm glad to hear that.

Please let me know if you run into trouble with the latest release.

gmogames commented 9 years ago

Yep, Working fine for me as well. really nice :)

nicoSWD commented 9 years ago

Awesome! Going to close this, then.

Please feel free to reopen the issue if the app crashes again.

Thanks!