search

nicolai-wachenschwan / arc-overhang-prusaslicer-integration

A 3D printer slicing algorithm that lets you print 90° overhangs without support material.
GNU General Public License v3.0
334 stars 26 forks source link

Fix MacOS PrusaSlicer bug #12

Closed rox97 closed 1 year ago

rox97 commented 1 year ago

Deleting the line to close the program and letting it close itself automatically, i fixed the EOF error that occurred in PrusaSlicer on MacOS. Fix #11 issue Some other instructions to use white spaces in paths both on unix like systems and windows

rox97 commented 1 year ago

I tried what you suggested me but didn't works, so what do you think about this solution? I updated the README.md whit some new instruction to use on unix like systems to skip the user input, but if you use the script in terminal without the flag -y, you can always use the end-input. Skip the end-input is the only way I found to make it works in PrusaSlicer on MacOS, I'm sorry.

rox97 commented 1 year ago

I'm really happy you liked my solution! Thank you for your work and your great tool!

nicolai-wachenschwan commented 1 year ago

Could I ask you for a favour? I googled a bit and found an automatic os detection: import platform platform.system() 'Windows' # for Linux it prints 'Linux',

Mac it prints `'Darwin'

This would reduce the User error to forget the -y flag. Do you have time to implement this ?

rox97 commented 1 year ago

I could give it a try, but in this way every macOS user would skip the user input in the end. the problem is that I can't detect if I'm using the script in PrusaSlicer on macOS or in terminal to skip the end-input only when I use it in the slicer

nicolai-wachenschwan commented 1 year ago

Yes, but the input is only needed when used as pp-Script to keep the Window Open. In concole mode this is automaticly happening. On mac this debugging feature wont be accessilbe either way

rox97 commented 1 year ago

Perfect. I don't have access to a windows terminal so I didn't know how the script ran on it. Please check the new pull request #13 and if you like the new solution, merge. Thank you!