nicolai-wachenschwan / arc-overhang-prusaslicer-integration

A 3D printer slicing algorithm that lets you print 90° overhangs without support material.

GNU General Public License v3.0

334 stars 26 forks source link

Various bug fixes and improvements #78

Open Wasupmacuz opened 7 months ago

Wasupmacuz commented 7 months ago

This branch of my fork primarily fixes #56 and fixes #77.

In the fix for #77, I also included some code to create a failsafe if unusual geometry causes arc-generation to fail.
It also resolves #66, as I've expanded the comment on specialCoolingZdist to explain how to disable Hilbert curves.
It may also sort out #47, regarding "Random Hibertcurve in the air" and "No arc at the middle overhang." That is, if "No arc at the middle overhang" was caused by #77.
Additionally, it fixes some spelling and grammatical errors in the script header and removes trailing whitespace to decrease file size, albeit minimally.
Other minor changes outlined in commits.

Nathan22211 commented 3 months ago

did you try fixing #59 yet, or did that get patched already?

Wasupmacuz commented 1 week ago

did you try fixing #59 yet, or did that get patched already?

@Nathan22211 That must have been related to another issue because yes, this fixes #59.

Nathan22211 commented 1 day ago

nice, I'll have to see if it's easy enough to bring the fixed-up code into lousassole and Keilish's orca slicer fork of the script because orca is my main slicer

Wasupmacuz commented 1 day ago

nice, I'll have to see if it's easy enough to bring the fixed-up code into lousassole and Keilish's orca slicer fork of the script because orca is my main slicer

You may or may not want to wait for just a few minutes. I'm just about to finalize some changes to the script on my dev fork that fixes some outstanding bugs that I found while looking at this Kyogre. The script will also run faster 👍