nicolas-steenhout / main

For my main site - jekyll and gh pages
MIT License
0 stars 2 forks source link

Menu button has incorrect values - smaller viewports #89

Closed vavroom closed 2 weeks ago

vavroom commented 3 weeks ago

◦ The “Menu/Close” control for the expandable navigation has both a name change, “Menu” to “Close”, and aria-expanded attribute. Screen readers announce “Close” as expanded content, which could be confusing

vavroom commented 3 weeks ago

@digilou I've assigned this one to you because it was your script - Happy to fix it if you know where to send me to change it.

The text of the button with an aria-expanded should remain the same regardless of the value of the attribute.