nicolasazrak / caddy-cache

Caching middleware for caddy
Mozilla Public License 2.0
109 stars 30 forks source link

Panic StreamedRecorder is not implement closeNotifier . #11

Closed stevensu1977 closed 7 years ago

stevensu1977 commented 7 years ago

src/github.com/mholt/caddy/caddyhttp/httpserver/responsewriterwrapper.go:41 - *cache.StreamedRecorder is not a closeNotifier

StreamedRecorder is not closeNotifier error .

nicolasazrak commented 7 years ago

Hi I seems that it should have been fixed with your pull request #12. Is there any way to reproduce it?

stevensu1977 commented 7 years ago

I used caddy:master (commit 3e2b1d145a0c60aee32821c353e8ecce4000ce3a), when you add run.go caddy-cache, build is not error, but when you request any path (use directive cache scope), get panic from responsewriterwrapper.go:41

error

25/Jun/2017:21:51:41 +0800 [PANIC /api/log?m=months] src/github.com/mholt/caddy/caddyhttp/httpserver/responsewriterwrapper.go:41 - *cache.StreamedRecorder is not a closeNotifier

stevensu1977 commented 7 years ago

already fix it