search

nicole-ashley / uBlock-Edge

uBlock Origin - An efficient blocker for Chromium, Firefox and Edge. Fast and lean.
GNU General Public License v3.0
328 stars 16 forks source link

Crash if uBlock is allowed for InPrivate #105

Open ghost opened 6 years ago

ghost commented 6 years ago

I am on the newest insider preview of windows 10. If I allow uBlock to be active in InPrivate Mode the extension crashs if I visit a website with ads like: https://pi-hole.net/pages-to-test-ad-blocking-performance/

It only happens with the uBlock Extension, other extensions are fine.

nicole-ashley commented 6 years ago

@s-john19 Thanks for the report. Can you please explain what you mean by "the extension crashes". What is the behaviour you experience? Can you provide screenshots or a screen recording?

ghost commented 6 years ago

The extension gets disabled. It disappears from the top bar. When I go to the extension settings it also shows it as disabled after I visited a website.

ghost commented 6 years ago

I uploaded a short clip to show the bug: https://www.youtube.com/watch?v=RKVvfUdASNA I added subtitles for translation to english, my browser is in german.

nicole-ashley commented 6 years ago

Thanks, the recording is really helpful. Interestingly it seems to be crashing even not in private mode (as seen in your video). Unfortunately I can't reproduce it. Let's watch this as the Windows Bug Bash continues, and see if anyone else reports it as well. Would you mind reporting it in the Feedback Hub (make sure diagnostics data is turned on while you reproduce it) and then sharing the link here?

ghost commented 6 years ago

I reported the bug in the feedback hub: https://aka.ms/Gty2zo I will reinstall my windows soon. After reinstall I will check it again.

What I can remember is: I got the bug suddenly. I enabled the extension for InPrivate after the release of the newest insider build. After that It worked some hours without any crash.

But I will see how it will be with a fresh install of windows :)

ghost commented 6 years ago

Here are also the diagnostics data from the feedback hub: https://1drv.ms/u/s!ArFhCfrKnT2NgZBqWMKrY9FW__b5Gw (OneDrive)

nicole-ashley commented 6 years ago

Thanks @s-john19, I'll watch this issue

ghost commented 6 years ago

After a fresh start with the windows 10 insider I realized that in the current insider you can't install any new extension :D Let us see what the next insider preview brings us :)

ghost commented 6 years ago

Ok I found out how you should be able to see my bug: With the newest insider preview it's now possible to install extensions again. So I installed uBlock Origin, I activated it for inPrivate and it was working. But now after 2-3 days I deactivated the uBlock Extension completely for 30 sec. After 30 sec I activated it and I got the bug again. Now I need to disable the extension for InPrivate again to get it working.

so: Use the extension some days. Disable it for 30 sec completely, enable it and you should get this bug.

KeeffromLondion commented 6 years ago

Hi Nik.
I have the same problem on 17110. If Allow in in InPrivate browsing is enabled, UO crashes. If it is disabled, UO works fine.

I have reported it in Feedback Hub as requested above. See https://aka.ms/N7frm6 Cheers

Keith

nicole-ashley commented 6 years ago

Microsoft have stated that they're "working with extension developers to get their extensions working for InPrivate mode". I'll do some more experimentation and reach out to Microsoft to see if there is anything specific I need to do to get this working more consistently.

KeeffromLondion commented 6 years ago

Thank you Nik.

UO has been working fine on 17128 with InPrivate enabled. I didn't notice anything in the release notes of any of the more recent builds that would suggest that the underlying problem has been fixed, though.

Cheers , Keith