nicolindemann / coinbase-moneymoney

Fetches balances from Coinbase API and returns them as securities
MIT License
19 stars 11 forks source link

feat: fix retrieving of CCYs #10

Closed udochrist closed 3 years ago

udochrist commented 3 years ago

Since XRP is now also not queryable (for me at least) i've taken a different approach. only query for a rate when the qty in coinbase > 0.

Remove all balances that are zero in Coinbase. This way the currency codes for such balances (atm. XRP and REP-V2) are not queried at all. besides this the change also removes tons of tokens i do not own from my moneymoney coinbase balance.

removed signature as a am not able to compute it myself

commit-lint[bot] commented 3 years ago

Contributors

udochrist

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR