search

niedev / RTranslator

Open source real-time translation app for Android that runs locally
Apache License 2.0
6.88k stars 519 forks source link

add translate for notification #57

Closed Agiens02 closed 4 months ago

Agiens02 commented 4 months ago

add translate for the notification

Agiens02 commented 4 months ago

So sorry for the mistake! I have corrected the English translation.

niedev commented 4 months ago

Don't worry, but you didn't send any commit, so the pull request hasn't been modified, if you want you can write in a comment here the simplified and traditional Chinese translations of "Conversation" and "WalkieTalkie" and I'll make the changes to the pull request 👍🏻.

Agiens02 commented 4 months ago

ok,here are the translations

in simplified Chinese: Conversation--->对话模式 Conversation mode is running...-->对话模式正在运行... WalkieTalkie-->对讲机模式 WalkieTalkie mode is running...-->对讲机模式正在运行...

in traditional Chinese: Conversation--->對話模式 Conversation mode is running...-->對話模式正在運行… WalkieTalkie-->對講機模式 WalkieTalkie mode is running...-->對講機模式正在運行…

simplified Chinese code: `

对话模式 对话模式正在运行… 对讲机模式 对讲机模式正在运行…` traditional Chinese code: ` 對話模式 對話模式正在運行… 對講機模式 對講機模式正在運行… `
niedev commented 4 months ago

No, I need the translations for only the word "Conversation" and for the word "WalkieTalkie".

You just sent me the translations of "Conversation mode" and "WalkieTalkie mode", please remove the "mode" in the translations, that's it.

Agiens02 commented 4 months ago

If you want the translations of the key word "Conversation" and the key word "WalkieTalkie" like this<string name="conversation" >对话模式</string>. it will be duplicated with the existing code, but in Chinese, we usually add the word "mode" after it, so I have to use a different key.

If you hope me to delete the word "模式" in Chinese, here are the code:

simplified Chinese code: `

对话模式正在运行… 对讲机模式正在运行…` traditional Chinese code: ` 對話模式正在運行… 對講機模式正在運行… ` If I misunderstood your meaning, I will close this pull request. Please forgive my poor English as well.Thank you for your patience
Agiens02 commented 4 months ago

@niedev Thanks again for your patience! I am still learning java, and I am not very familiar with the naming conventions, thank you very much for your correction!

niedev commented 4 months ago

Don't worry, I used other string resources for the notification titles, the xxx_mode resources can be left like this.