yanndavin commented 6 years ago

Add the possibility to get wubi codes for a characters sequence. Add the possibility to get pinyin in utf8 with accent rather that ascii with tone digit code.

nieldlr commented 5 years ago

This is really amazing @yanndavin! I'm so sorry I missed this completely. I would love to get this merged into HanziCraft. Especially the Pinyin accents too.

Would you be up for merging in the latest code to get some of the conflicts resolved? Let me know! Otherwise I could also possibly look into getting this merged.

Happy either way.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a482fc7). Click here to learn what that means. The diff coverage is 95.45%.

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   88.67%           
=========================================
  Files             ?       17           
  Lines             ?      618           
  Branches          ?      101           
=========================================
  Hits              ?      548           
  Misses            ?       58           
  Partials          ?       12

Impacted Files	Coverage Δ
lib/dictionary.js	`88.3% <95.45%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a482fc7...12aa17f. Read the comment docs.

yanndavin commented 5 years ago

I've looked for the merge but there is still errors on travis I don't explain. Any idea ?

benlieb commented 4 years ago

Looking forward to getting this in!

nieldlr / hanzi

Add the possibility to get wubi codes for a characters sequence. #50

Codecov Report