search

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
98 stars 526 forks source link

Update Insulin Peak Time #348

Closed tmhastings closed 2 months ago

tmhastings commented 4 months ago

Correct identifications of Ultra-rapid and Rapid-acting insulins in the Insulin Peak Time Popup

snickerdoodleparent commented 4 months ago

Refer: PR347

Does this need an update to localize strings to show up in the pop-up in the app? Line 2034

Suggest:

/ "Insulin Peak Time" / "Time of maximum blood glucose lowering effect of insulin, in minutes. Beware: oref assumes for ultra-rapid (Lyumjev, Fiasp) & rapid-acting (Humalog, Novolog, Apidra) curves minimum (35 & 50 min) and maximum (100 & 120 min) applicable insulinPeakTimes. Using a custom insulinPeakTime outside these bounds will result in issues with Trio, longer loop calculations and possible red loops." = "Time of maximum blood glucose lowering effect of insulin, in minutes. Beware: oref assumes for ultra-rapid (Lyumjev, Fiasp) & rapid-acting (Humalog, Novolog, Apidra) curves minimum (35 & 50 min) and maximum (100 & 120 min) applicable insulinPeakTimes. Using a custom insulinPeakTime outside these bounds will result in issues with Trio, longer loop calculations and possible red loops.";

Novolog is used in Loop. In some places (Canada, for one) it's referred to as Novorapid.

Not sure about the timing.

MikePlante1 commented 4 months ago

Does this need an update to localize strings to show up in the pop-up in the app? Line 2034

To show in the app, the change needs to be added to PreferencesEditorStateModel.swift#L382 and in order for localizations to work, all 23 Localizable.strings files need to be updated. Otherwise all translated apps would just show the untranslated text from PreferencesEditorStateModel.swift

Novolog is used in Loop. In some places (Canada, for one) it's referred to as Novorapid.

Not sure about the timing.

The options for insulin in Trio come from Loop and are Apidra, Humalog, Novolog, Fiasp, and Lyumjev... so I think it's best to just leave this tooltip as Novolog. I do think it could be beneficial to update the description in LoopKit in InsulinType.swift as well as all 11 Localizable.strings for LoopKit

I'd suggest something like:

NovoLog (insulin aspart) is a rapid-acting insulin made by Novo Nordisk. It also goes by the name NovoRapid

mountrcg commented 3 months ago

Btw, if we could apply the boundary concept to this it would help a lot. I had raised an issue with oref at the time. Thetry to fix it in oref went not ok and raised other issues, so no solution there yet. However I guess that needs splitting peak time into 3 peak times for the three insulin models.