nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
98 stars 526 forks source link

Rename "G6" -> "G6 / ONE" and "G7" -> "G7 / ONE+" #379

Closed LiroyvH closed 1 month ago

LiroyvH commented 3 months ago

Is your feature request related to a problem? Please describe.

Trio in the CGM selection only declares support for G6 and G7, whilst ONE and ONE+ also work with them (in that order) respectively.

Describe the solution you'd like

Change CGM Selection / configuration options, menu's, etc. to read "Dexcom G6 / ONE" and "Dexcom G7 / ONE+" instead of "Dexcom G6" or "Dexcom G7" respectively.

Describe alternatives you've considered

Leave it as it is and let users figure it out themselves, just to f- with 'em.

Additional context

Primarily relevant in Settings -> CGM and its subsettings/submenus. (And localization strings)

Technical Details

There are no additional dependencies other than the official Dexcom-apps of the respective sensor/transmitter.

User Impact

Users will understand which option to choose if they wish to use ONE or ONE+, whereas they currently may believe they're unsupported or don't know what to select.

Sjoerd-Bo3 commented 1 month ago

@LiroyvH I think #424 should fix this

bjornoleh commented 1 month ago

@LiroyvH I think #424 should fix this

Confirmed!