search

nightscout / Trio

Trio - an automated insulin delivery system for iOS based on the OpenAPS algorithm with adaptations.
https://docs.diy-trio.org/en/latest/
MIT License
98 stars 534 forks source link

Log external insulin retrospectively #47

Closed bjornoleh closed 6 months ago

bjornoleh commented 7 months ago

Question raised in Discord: @Sjoerd-Bo3 asked: "is it not possible in Oiaps to add insulin retrospectively? So when I injected insulin manually, and forgot to log. I could in 3.x but was it not in there before?"

@dnzxy listed these relevant PRs from iAPS:

https://github.com/Artificial-Pancreas/iAPS/pull/267 https://github.com/Artificial-Pancreas/iAPS/pull/271 https://github.com/Artificial-Pancreas/iAPS/pull/289 and adjacent: https://github.com/Artificial-Pancreas/iAPS/pull/272

bjornoleh commented 7 months ago

@BrianWieder , is this issue closed with #80 and #93?

BrianWieder commented 7 months ago

Not quite yet, https://github.com/Artificial-Pancreas/iAPS/pull/272 still needs to be ported over, and https://github.com/Artificial-Pancreas/iAPS/pull/314 is sort of related as well, that I wanted to port over.

bjornoleh commented 7 months ago

Is this something that could make it to v1.0 in the next few days ☺️

Perhaps it’s not such a big rush to get these last bits ported, just checking 🙂

Sjoerd-Bo3 commented 7 months ago

I'm already using it from the log :)

bjornoleh commented 7 months ago

I'm already using it from the log :)

I was referring to porting of the iAPS PRs Nr 272 and 314 mentioned above, the other changes are already merged :-)

BrianWieder commented 7 months ago

Sure, will work on porting those PRs tonight. Sorry, been a hectic past week at work.

bjornoleh commented 6 months ago

Closed as completed by:

80

93

110

140