nightscout / nightguard

iOS and WatchOS Client for the Nightscout CGM System
GNU Affero General Public License v3.0
243 stars 159 forks source link

Nightguard from source #220

Closed j-kaltes closed 1 year ago

j-kaltes commented 1 year ago

nightguard I tried to run Nightguard in xCode, but it failed (see picture). The README.md says that "you will have to modify the SliderRow in the following way:"

public final class SliderRow: Row<SliderCell>, RowType {
    public var steps: UInt = 20
    public var shouldHideValue = false
    public var lastSelectedValue : Float?

    required public init(tag: String?) {
        super.init(tag: tag)
    }
}

But the only SliderRow I can find is "extension SliderRow" in CustomFormViewController.swift which seems to be something totally different.

dhermanns commented 1 year ago

Hi!

did you do a

pod install

before? It should pull the pod dependencies. And this is where you have to update the mentioned code.

Jaap Korthals Altes @.***> schrieb am Fr. 24. März 2023 um 17:33:

[image: nightguard] https://user-images.githubusercontent.com/72013079/227585837-8fff06b3-b596-4e4e-aa73-8d010a558eb0.png I tried to run Nightguard in xCode, but it failed (see picture). The README.md says that "you will have to modify the SliderRow in the following way:"

public final class SliderRow: Row, RowType { public var steps: UInt = 20 public var shouldHideValue = false public var lastSelectedValue : Float?

required public init(tag: String?) {
    super.init(tag: tag)
}

}

But the only SliderRow I can find is "extension SliderRow" in CustomFormViewController.swift which seems to be something totally different.

— Reply to this email directly, view it on GitHub https://github.com/nightscout/nightguard/issues/220, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYPBFI4H5ZL6UXDPQQFCK3W5XEGPANCNFSM6AAAAAAWGY65PE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

j-kaltes commented 1 year ago

pod install and a path name change helped me somewhat further, but it still doesn't build. target ambigious

dhermanns commented 1 year ago

Now you would have to adjust the SliderRow the way described on the github page.

Jaap Korthals Altes @.***> schrieb am Fr. 24. März 2023 um 18:01:

pod install and a path name change helped me somewhat further, but it still doesn't build. [image: target] https://user-images.githubusercontent.com/72013079/227591402-21fd1e7e-530f-42e9-954d-bb51b870a1be.png [image: ambigious] https://user-images.githubusercontent.com/72013079/227591433-85dc58a3-e8e7-48fd-a5e3-36bcb70946cb.png

— Reply to this email directly, view it on GitHub https://github.com/nightscout/nightguard/issues/220#issuecomment-1483127427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYPBFMLGY7WLI7747ZE623W5XHORANCNFSM6AAAAAAWGY65PE . You are receiving this because you commented.Message ID: @.***>

j-kaltes commented 1 year ago

Yes, when I just add the code before the extension, it does work. Why isn't it uploaded to the github?

dhermanns commented 1 year ago

Its code modifying the pod dependency. So you could try to provide a pull request for the eureka framework.