Nightguard cannot be build because files are missing

nightscout / nightguard

iOS and WatchOS Client for the Nightscout CGM System

GNU Affero General Public License v3.0

243 stars 159 forks source link

Nightguard cannot be build because files are missing #267

Closed Joerg-Schoemer closed 11 months ago

Joerg-Schoemer commented 11 months ago

Pods.xcodeproj missing in workspace Content of Products missing Folder Pods missing

I've made a clean clone of nightguard and opened Xcode within the fresh folder.

dhermanns commented 11 months ago

I see. Fixing this...

dhermanns commented 11 months ago

Should work now. I did a fresh checkout and could build now fine. Have a look at the updated readme, too.

poml88 commented 11 months ago

Excellent. Thanks for fixing the Podfile. And thanks for updating the README, it will help people. Could you also fix the string files: Build input files cannot be found: '/Users/dirk/workspace/nightguard/nightguard/fi-FI.lproj/Duration.strings', '/Users/dirk/workspace/nightguard/nightguard/de.lproj/Duration.strings', '/Users/dirk/workspace/nightguard/nightguard/Base.lproj/Duration.storyboard'? The Duration.storyboard location has to be set "relative to group" and then the nightguard folder selected as a base. And for the README it could be usefule to mention in what files the group profile needs to be changed. It seems not worthwhile to do a pull request for this... Thanks!

PS: Otherwise it indeed builds fine now. Had, as you suggested, no create a nightguard scheme.

dhermanns commented 11 months ago

I didn't get these errors. So not quite sure what you ment. Feel free to provide a PR for it.

poml88 commented 11 months ago

Yes, I guess, because you are Dirk. :-) It is easy: Open the workspace and go to nightguard - rescources - Duration.storyboard. In the file inspector you will see that the location is set to "absolute path". "Users/Dirk/..." It is a bit complicated to make a PR for that, because it is a xcode configuratin detail.

See screenshot. This is the corrected setting "relative to group".

Clipboard01

Joerg-Schoemer commented 11 months ago

Hi Dirk, can you add in the README.md a developer hint to request critical alert permissions from apple. Kind regards, Jörg

Joerg-Schoemer commented 11 months ago

The Duration.storyboard points to “/Users/dirk/workspace/nightguard/nightguard/Duration.storyboard” and thus results in a missing file in the project.

dhermanns commented 11 months ago

Added this one: https://github.com/nightscout/nightguard/commit/6d6b62851ada5bbae8af651c1f86307ec3c3c8ae

poml88 commented 11 months ago

Thanks to both of you for fixing these issues. Still waiting for the critical notification entitlement from Apple. Meanwhile having fun with the testflight build!

dhermanns commented 11 months ago

Thanks to both of you for fixing these issues. Still waiting for the critical notification entitlement from Apple. Meanwhile having fun with the testflight build!

Have a look at the readme.md if you don't want to wait.