Fix empty HTML attributes being rendered needlessly by the Nunjucks environment

nihruk / design-system

Design System

https://design-system.nihr.ac.uk

MIT License

3 stars 2 forks source link

Fix empty HTML attributes being rendered needlessly by the Nunjucks environment #277

Closed bartfeenstra closed 1 year ago

bartfeenstra commented 1 year ago

Our custom htmlAttributes Nunjucks filter occasionally renders empty HTML attributes when those attributes are in fact not needed (which is why they are empty).

How to test

Confirm that https://design-system.nihr.ac.uk/component/table shows empty attributes in the code examples, such as <tr class="">.
Confirm that https://design-system-git-fix-empty-html-attributes-nihruk.vercel.app/component/table does not show these empty attributes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 31, 2023 11:09am