Closed Felixkruemel closed 4 years ago
I had an similar issue where my rgba64be input pngs were being converted to transparent pngs. I lowered the pixel format to rgb8 (8 bits per color), and that fixed it. Converting the input to a JPG with 100% quality might also work.
@skerit I have tried converting it to jpg, but it still results in this behaviour.
I really don't know what the issue is then.
Is there any logging I could provide?
I had an similar issue where my rgba64be input pngs were being converted to transparent pngs. I lowered the pixel format to rgb8 (8 bits per color), and that fixed it. Converting the input to a JPG with 100% quality might also work.
alpha channel was not handled properly, but it has been fixed now.
Just for the current standing: So, did remove the driver with DUD, rebooted, installed it again, rebooted, tried realsr again with the same result. Doesn't seem to have anything to do with the driver.
Does anybody have the same GPU or one of the RTX series? Maybe it's a problem there
I've tested it with a 20x20 image now, just to see wether it may be a graphic storage problem. But nope, same behaviour here Original:
After Upscaling:
Tried the latest artifact from today - still the same
There seems to be a problem on your system. I have loaded and tested the image, I get a good image displayed here without any problems. Please check the MD5 sum for your Original. My Download is: 449dff1cdf8ecb58af3598a9b5d78eeb
For the .zip file (using this Windows build) it's 3d48af76f5275217b0826fbe39f45bfa and for the .exe it's 6f839e4d20bf40dcfbbf26b84e110ffe
What had you tested @frankenstein91 ? If you are using Linux, that error may not exist there.
Edit: The original picture is 449dff1cdf8ecb58af3598a9b5d78eeb So that's the same
I have tested your 20x20 image on a notebook with Linux and Intel GPU. And I want to make sure we're testing the same image.
So then it seems GH doesn't change the picture and it's the same @frankenstein91
Update: I tried it on my SurfacePro 7 with an Intel Iris GPU. The result is a black picture.
Something definitely is wrong with it: Input: Output:
Console Log:
The process was also really fast with 2s or so. Too fast for an iGPU I would say.
@nihui on my pc win10 pro 10.0.18363.836 nvidia gtx1070 driver 446.14 realsr-ncnn-vulkan from pre-compiled realsr-...-20200530-windows.zip - full black image from CI realsr-...-artifact-windows-2016 and realsr-...-artifact-windows-2019 - full black image srmd-ncnn-vulkan from pre-compiled srmd-...-20200530-windows.zip - great work waifu2x-ncnn-vulkan from pre-compiled waifu2x-...-20200530-windows.zip - green image
I'm ready for cooperation, help, testing.
Using Win10 Pro + NVIDIA GTX 970 (latest driver, v. 446.14), I am also getting fully black images with tiny file sizes. I have tried adjusting the settings and upscaling different file types, but the result is always the same. For comparison, srmd-ncnn-vulkan works fine for me, but waifu2x-ncnn-vulkan unfortunately does not (green/blue color issues).
Console example (realsr-ncnn-vulkan):
@nihui I get the same garbage noise output as @Felixkruemel Tried jpg and png as input. No difference.
@lextra2 Which GPU do you have and which OS?
@nihui Can we help you identifying this issue?
https://github.com/nihui/realsr-ncnn-vulkan/actions/runs/122496515
build with latest ncnn, include two critical fix for fp16 storage on integrated gpu
@nihui nvidia gtx1070 realsr-ncnn-vulkan-artifact-windows-2016 fully black images realsr-ncnn-vulkan-artifact-windows-2019 fully black images
@nihui For me still the same noisy image as in the first post :/
@nihui can't test today. will test tomorrow @Felixkruemel my os is w10 1909 my gpu is radeon rx 5700
Using an Nvidia GTX 970, having tried different tile sizes and thread configs:
for me Using Nvidia GTX 1080 8GB:
realsr-ncnn-vulkan-artifact-windows-2016: black image realsr-ncnn-vulkan-artifact-windows-2019: black image
@nihui has published a fix on ncnn today fix memorydata test on nvidia gpu
Maybe that solves the problem on the nvidia side. Although it's unlikely, but possible.
@nihui I just installed Kubuntu on my rig. It works there with no issues. Seems to be something of with the Windows ports then. Here's a before and a after and let's say it that way: The results are literally shocking good, would be great if the Windows Port would work too. Before
After
On Windows I still get those black or noisy images.
If it helps any: No problems on AMD RX5700XT w/ThreadRipper 1950x. Win10 19640.
realsr-ncnn-vulkan.exe -s 4 -v -m models-DF2K -j 2:3:3
One oddity I did notice; increasing tile size (300) gives a smaller output filesize when compared to Auto.
Would anyone be willing to upload a Windows build of realsr-ncnn-vulkan that includes @nihui's newly-updated ncnn? I am sadly unable to build it myself and would really like to see if this change fixes the black image problem.
the problem is the display language... i changed it from german to english and now its working... on 2 systems of me its working now
@nihui @Xyz00777 OMG! But this bug no "Display language" for me, i was changing the settings, no effect, i change "Regional Format" to English and realsr-ncnn-vulkan waifu2x-ncnn-vulkan working without problems
did you restart your machine or only logged in again? when only logged in than restart it becuase first after a full system restart it is changed correctly
without restart and relogin, just reopen cmd
than it cant work. you have to restart the system completly first after that it changed all to english
I can confirm. Changing the following setting fixes both realsr noise output aswell as waifu2x missing color channel output.
Actually insane to figure this out.
@Xyz00777 my Display language Russian, Regional Format Russian. after reboot pc, i start record video, and run realsr-ncnn-vulkan (black image), after i change Regional Format to English (United States) and again run realsr-ncnn-vulkan (work good (without reboot pc and relogin)), after i change Regional Format to Russian and again run realsr-ncnn-vulkan (black image (without reboot pc and relogin))
i upload my video to youtube.com: https://www.youtube.com/watch?v=uuNw4tuUbIc
You don't need to change region format or reboot. see https://github.com/nihui/waifu2x-ncnn-vulkan/issues/59#issuecomment-639564174 for the correct solution
reproduced will work out a fix in ncnn and push a new release Thanks to all
@nihui Work good for me in laters CI Artifacts. Thank You!
I think we can close this issue now. The last release should have fixed it. Does anybody still have this issue?
Yeah. Issues can be closed. It works now.
If I try to upscale any png picture with RealSR ncnn it's unusable slow at around 10s/image (SRMD does 2fps) and produces these results: I updated the GPU drivers to the newest version (445.87) but still the same result. What is going wrong?
My system config: Windows 10 RTX 2060 Super Ryzen 7 3700X 32GB DDR4
Most of the actual upscaling time is invested in decoding the picture (where I think the problem lays). The actual upscale goes really fast. @nihui