search

nikic / FastRoute

Fast request router for PHP
Other
5.13k stars 444 forks source link

replace FastRoute\ConfigureRoutes with FastRoute\RouteCollector #281

Closed k-msalehi closed 8 months ago

k-msalehi commented 8 months ago

FastRoute\ConfigureRoutes is Undefined,

lcobucci commented 8 months ago

You're looking at the documentation of the new v2, please refer to the readme in your vendor folder or the respective tag.

k-msalehi commented 8 months ago

You are correct. I apologize for the incorrect pull request. This is my first time using FastRoute. I installed it via composer require nikic/fast-route and attempted to understand how to use it. I copied the code from the main GitHub repo page, but it didn't work. Since Composer installs version 1.x by default, but the README.md in the main branch is for version 2.x, perhaps a notice would have been helpful.

lcobucci commented 8 months ago

I completely understand it 👍

We already have a pre-release version for v2 and hopefully that notice will not be there for long, but feel free to send a PR with a suggestion if you believe that would help other folks as well!