nikitavoloboev / config

Apps/CLIs/configs I use on macOS/iOS. Fish, Karabiner, Cursor..
MIT License
20.59k stars 839 forks source link

monokai night iterm colors #92

Closed caarlos0 closed 5 years ago

caarlos0 commented 5 years ago

Hi, thanks for presenting me to the Monokai Night theme, it's awesome!

About the itermcolors, my OCD hit me when I saw that the colors of the terminal inside vscode using monokai night were different from the ones in iterm using monokai night... I found out that some of the colors differ, so, I've copied the terminal theme colors from the vscode theme:

    "terminal.ansiBlack": "#333333",
    "terminal.ansiBlue": "#6a7ec8",
    "terminal.ansiBrightBlack": "#666666",
    "terminal.ansiBrightBlue": "#819aff",
    "terminal.ansiBrightCyan": "#66d9ef",
    "terminal.ansiBrightGreen": "#a6e22e",
    "terminal.ansiBrightMagenta": "#ae81ff",
    "terminal.ansiBrightRed": "#f92672",
    "terminal.ansiBrightWhite": "#f8f8f2",
    "terminal.ansiBrightYellow": "#e2e22e",
    "terminal.ansiCyan": "#56adbc",
    "terminal.ansiGreen": "#86b42b",
    "terminal.ansiMagenta": "#8c6bc8",
    "terminal.ansiRed": "#c4265e",
    "terminal.ansiWhite": "#e3e3dd",
    "terminal.ansiYellow": "#b3b42b",
    "terminal.background": "#262626",
    "terminal.border": "#161616",
    "terminal.foreground": "#dddddd",
    "terminal.selectionBackground": "#ffffff24",
    "terminalCursor.background": "#262626",
    "terminalCursor.foreground": "#f2f2f2",

into my own monokai night theme.

Terms look equal now on both iterm and vscode:

image

image

if it interests you, I can open a PR... in any case, here is the link: https://github.com/caarlos0/macOS/blob/master/Monokai%20Night.itermcolors

Cheers!

nikitavoloboev commented 5 years ago

if it interests you, I can open a PR

Please do ❤️

nikitavoloboev commented 5 years ago

Although I quite like #1F1F1F as background. Same as editor. And I switch between iTerm/VSCode often.

nikitavoloboev commented 5 years ago

That's the only change I'd make to your theme to make it perfect for me. So if you do a PR, I'll only change the background to #1F1F1F and merge.

caarlos0 commented 5 years ago

image

Looks the same for me haha

the tree on vscode has a darker background though...