Improved NavBar and Toggle

nilisha-jais / Musicophilia

A platform for music lovers

https://musicophilia.netlify.app/

MIT License

42 stars 121 forks source link

Improved NavBar and Toggle #501

Closed gunjan-g closed 3 years ago

gunjan-g commented 3 years ago

Description

Fixes issue #499 The navbar is more proper according to UI design and toggle button is visible in all the pages

Checklist

[ yes] I am making a proper pull request, not a spam.
[ yes] I've checked the issue list before deciding what to submit.

Add relevant screenshot or video (if any)

Spacing between navbar

Toggle Button is now visible properly

netlify[bot] commented 3 years ago

:heavy_check_mark: Deploy Preview for musicophilia ready!

:hammer: Explore the source changes: 11d2012ca816ebc9a2c66d757035d0ad0344f0a1

:mag: Inspect the deploy log: https://app.netlify.com/sites/musicophilia/deploys/60eb0a6f8512980007d99f8f

:sunglasses: Browse the preview: https://deploy-preview-501--musicophilia.netlify.app

gunjan-g commented 3 years ago

Hey @gunjan-g , please configure your local git with proper credentials. We are getting commits from your second account - @Gunjangupta12

sir, just by changing config, will it be applicable to all my previous commits as well?

niloysikdar commented 3 years ago

No @gunjan-g , it will not reflect any changes to your previous commits. I didn't notice it earlier, noticed now, sorry :)

gunjan-g commented 3 years ago

No @gunjan-g , it will not reflect any changes to your previous commits. I didn't notice it earlier, noticed now, sorry :)

sir, sorry i didn't know but that wouldn't count as my contribution in lgmsoc then

niloysikdar commented 3 years ago

No @gunjan-g , it will not reflect any changes to your previous commits. I didn't notice it earlier, noticed now, sorry :)

sir, sorry i didn't know but that wouldn't count as my contribution in lgmsoc then

Not sure @gunjan-g , but your main (this one) account hasn't been added to the contributors' list as you didn't push code from this account.

niloysikdar commented 3 years ago

Capture

gunjan-g commented 3 years ago

No @gunjan-g , it will not reflect any changes to your previous commits. I didn't notice it earlier, noticed now, sorry :)

sir, sorry i didn't know but that wouldn't count as my contribution in lgmsoc then

Not sure @gunjan-g , but your main (this one) account hasn't been added to the contributors' list as you didn't push code from this account.

sir i'll do the required changes and then push the code again

niloysikdar commented 3 years ago

Sure @gunjan-g , let me know if you need any help.

gunjan-g commented 3 years ago

Sir, please consider the new pr made